Add cryptoCb hook to one-shot CMAC functions#7059
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Jan 16, 2024
Merged
Conversation
bigbrett
force-pushed
the
cryptocb-oneshot-cmac
branch
2 times, most recently
from
3368c2f to
ad35458
Compare
billphipps
reviewed
Dec 13, 2023
Contributor
billphipps
left a comment
billphipps
left a comment
There was a problem hiding this comment.
Minor nits and some ideas. Feel free to resolve at your discretion.
bigbrett
force-pushed
the
cryptocb-oneshot-cmac
branch
from
294504d to
8fccbfc
Compare
bigbrett
force-pushed
the
cryptocb-oneshot-cmac
branch
from
d026b37 to
101a03c
Compare
billphipps
requested changes
Jan 4, 2024
Contributor
billphipps
left a comment
billphipps
left a comment
There was a problem hiding this comment.
A few missed parameter checks and a couple of questions. Feel free to resolve at your discretion and I'll quickly approve.
bigbrett
force-pushed
the
cryptocb-oneshot-cmac
branch
2 times, most recently
from
f9df415 to
e45431d
Compare
…ryptoCb tests; add context argument to CMAC generate_ex
bigbrett
force-pushed
the
cryptocb-oneshot-cmac
branch
from
e45431d to
abbf9f2
Compare
billphipps
approved these changes
Jan 15, 2024
Contributor
Author
|
Jenkins retest this please |
Contributor
|
retest this please |
dgarske
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
Added CMAC cryptoCb to
myCryptoDevCbto exercise new and existing code paths